From 6ed275f6cf01d899dac596681e2cd0aa0d4a3a74 Mon Sep 17 00:00:00 2001 From: mrjvs Date: Sun, 14 Sep 2025 21:32:22 +0200 Subject: [PATCH] fix: fixed xml rendering bugs/inconsistencies --- src/services/npts.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/services/npts.ts b/src/services/npts.ts index a3c94e5..93c3753 100644 --- a/src/services/npts.ts +++ b/src/services/npts.ts @@ -8,12 +8,14 @@ import type { HydratedTaskDocument } from '@/types/mongoose/task'; const npts = express.Router(); +const xmlHeadSettings = { encoding: 'UTF-8', version: '1.0' }; + function buildFile(task: HydratedTaskDocument, file: HydratedFileDocument): any { return { Filename: file.name, DataId: file.data_id, Type: file.type, - Url: `https://${config.domains.npdi}/p01/data/1/${task.title_id}/${file.data_id}/${file.hash}`, + Url: `https://${config.domains.npdi}/p01/data/1/${task.boss_app_id}/${file.data_id}/${file.hash}`, Size: file.size, Notify: { New: file.notify_on_new.join(','), @@ -22,8 +24,6 @@ function buildFile(task: HydratedTaskDocument, file: HydratedFileDocument): any }; } -// TODO tasksheet ID is unused - what is it for? - npts.get('/p01/tasksheet/:id/:bossAppId/:taskId', async (request, response) => { const { bossAppId, taskId } = request.params; @@ -46,7 +46,7 @@ npts.get('/p01/tasksheet/:id/:bossAppId/:taskId', async (request, response) => { }; response.set('Content-Type', 'application/xml; charset=utf-8'); - response.send(xmlbuilder.create(xmlContent, { headless: true }).end({ pretty: true })); + response.send(xmlbuilder.create(xmlContent, xmlHeadSettings).end({ pretty: true })); }); npts.get('/p01/tasksheet/:id/:bossAppId/:taskId/:fileName', async (request, response) => { @@ -74,7 +74,7 @@ npts.get('/p01/tasksheet/:id/:bossAppId/:taskId/:fileName', async (request, resp }; response.set('Content-Type', 'application/xml; charset=utf-8'); - response.send(xmlbuilder.create(xmlContent, { headless: true }).end({ pretty: true })); + response.send(xmlbuilder.create(xmlContent, xmlHeadSettings).end({ pretty: true })); }); const router = express.Router();