From 4895456bb025bc6dbbde00b9faf0de5e19caba05 Mon Sep 17 00:00:00 2001
From: Yonle <yonle@protonmail.com>
Date: Sat, 16 May 2026 09:39:54 +0700
Subject: [PATCH] fix: display error in a friendlier way on rankings

migrate from status overlays to displaying within container
---
 AquaNet/src/pages/Ranking.svelte                             | 5 ++---
 .../java/icu/samnyan/aqua/net/games/GameApiController.kt     | 2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/AquaNet/src/pages/Ranking.svelte b/AquaNet/src/pages/Ranking.svelte
index 11432abc..c942835f 100644
--- a/AquaNet/src/pages/Ranking.svelte
+++ b/AquaNet/src/pages/Ranking.svelte
@@ -3,7 +3,6 @@
   import { title } from "../libs/ui";
   import { GAME } from "../libs/sdk";
   import type { GenericRanking } from "../libs/generalTypes";
-  import StatusOverlays from "../components/StatusOverlays.svelte";
   import type { GameName } from "../libs/scoring";
   import { GAME_TITLE } from "../libs/i18n";
   import { t } from "../libs/i18n";
@@ -86,9 +85,9 @@
     <Tooltip triggeredBy=".name" loading={hoverLoading}>
       <UserCard username={hoveringUser} {game} setLoading={l => hoverLoading = l} />
     </Tooltip>
+  {:else}
+    <p>{error}</p>
   {/if}
-
-  <StatusOverlays error={error} loading={!loadedPages} />
 </main>
 
 <style lang="sass">
diff --git a/src/main/java/icu/samnyan/aqua/net/games/GameApiController.kt b/src/main/java/icu/samnyan/aqua/net/games/GameApiController.kt
index 0b5d0f56..496757c6 100644
--- a/src/main/java/icu/samnyan/aqua/net/games/GameApiController.kt
+++ b/src/main/java/icu/samnyan/aqua/net/games/GameApiController.kt
@@ -57,7 +57,7 @@ abstract class GameApiController<T : IUserData>(val name: String, userDataClass:
         val time = millis()
 
         // Check cache validity
-        if (rankingCache.isEmpty()) (500 - "Ranking is computing... please wait")
+        if (rankingCache.isEmpty()) (500 - "Rank is empty or is currently computing. Please come back later.")
 
         val reqUser = token?.let { us.jwt.auth(it) }?.let { u ->
             // Optimization: If the user is not banned, we don't need to process user information